Messages in this thread |  | | Date | Wed, 29 Apr 2026 12:30:20 +0200 | | From | Uwe Kleine-König (The Capable Hub) <> | | Subject | Re: [PATCH net-next] net: Consistently define pci_device_ids using named initializers |
| |
Hello Marc,
On Wed, Apr 29, 2026 at 11:10:21AM +0200, Marc Kleine-Budde wrote: > On 28.04.2026 19:18:44, Uwe Kleine-König (The Capable Hub) wrote: > > }, > > - { 0,} > > + { } > > Nitpick: can you convert the terminating entry to follow the same style > as the rest of the driver: > > diff --git a/drivers/net/can/sja1000/plx_pci.c b/drivers/net/can/sja1000/plx_pci.c > index a03553b80a5d..d69ff0ccfd94 100644 > --- a/drivers/net/can/sja1000/plx_pci.c > +++ b/drivers/net/can/sja1000/plx_pci.c > @@ -353,8 +353,8 @@ static const struct pci_device_id plx_pci_tbl[] = { > PCI_DEVICE_SUB(ASEM_RAW_CAN_VENDOR_ID, ASEM_RAW_CAN_DEVICE_ID, > ASEM_RAW_CAN_SUB_VENDOR_ID, ASEM_RAW_CAN_SUB_DEVICE_ID_BIS), > .driver_data = (kernel_ulong_t)&plx_pci_card_info_asem_dual_can, > - }, > - { } > + }, { > + } > }; > MODULE_DEVICE_TABLE(pci, plx_pci_tbl);
That might be subjective. I also see some value to have the terminating entry stand out a bit in the formatting and so I usually kept the entry as it was.
If you prefer I can rework the can drivers at least to match your taste.
As you didn't object to have the can drivers converted as part of the drivers/net patch, I assume that part is OK for you?!
Best regards Uwe [unhandled content-type:application/pgp-signature] |  |