lkml.org 
[lkml]   [2026]   [Apr]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH 06/24] rust: pci: implement Sync for Device<Bound>
From
On Tue Apr 28, 2026 at 1:52 AM CEST, Gary Guo wrote:
> Given that you're now implementing for two ctx marker types, it might worth changing
> the existing one to spell out the `Normal` explicitly (also saves you from
> having to spell it out in the comment).

I don't think this belongs in this commit and I'm not sure it is worth creating
new ones for only this purpose.

> It might also make sense to write a comment to say that why it's not the case
> for `Device<Core>`.

I think the documentation in [1] explains (or at least implies) it. Where do you
suggest to put such a comment? It seems a bit repretitive to have it for all bus
devices.

[1] https://rust.docs.kernel.org/kernel/device/struct.Core.html

\
 
 \ /
  Last update: 2026-04-28 12:26    [W:0.092 / U:18.277 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and my Meterkast|Read the blog