Messages in this thread |  | | Date | Mon, 27 Apr 2026 17:25:23 +0200 | | From | Andrew Lunn <> | | Subject | Re: [PATCH] [v4] wiznet: convert to GPIO descriptors |
| |
On Mon, Apr 27, 2026 at 05:17:24PM +0200, Arnd Bergmann wrote: > On Mon, Apr 27, 2026, at 16:50, Rob Herring wrote: > > On Mon, Apr 27, 2026 at 04:28:29PM +0200, Arnd Bergmann wrote: > >> > >> The CONFIG_WIZNET_BUS_SHIFT value was apparently meant to be set > >> at compile time to a machine specific value. This was always broken > >> for multiplatform configurations with conflicting requirements, and > >> in the mainline kernel it was set to 0 anyway. Leave it defined > >> locally as 0 but rename it to something without the CONFIG_ prefix. > >> > >> Acked-by: Rob Herring <robh@kernel.org> > > > > Well, 3 years later and I'm a bit grumpier seeing .txt binding > > additions. A new compatible plus new property we generally require > > converting the binding first. But I'm not going to revoke my ack here. > > > > Is there even a known user for this new compatible? > > No, I'm not aware of any users neither the old nor the new > compatible, it only popped up from my backlog of patches > because of its usage of legacy GPIOs. From what I can > tell, the only users of the non-DT MMIO interface were > out of tree arch/blackfin/ boards.
I would suggest giving Nicolas Saenz Julienne time to speak up. If Nicolas does not require it any more, i suggest removing it. That fits with what we are trying to do at the moment in netdev, remove old drivers.
Andrew
|  |