lkml.org 
[lkml]   [2026]   [Apr]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 3/3] iio: light: vcnl4000: register an IIO device with a device-managed function
On Wed, Apr 01, 2026 at 02:22:38PM +0300, Erikas Bitovtas wrote:
> Use a device-managed counterpart of iio_device_register() and remove the
> redundant iio_device_unregister() call in driver remove function.

...

> - ret = iio_device_register(indio_dev);
> + ret = devm_iio_device_register(dev, indio_dev);
> if (ret < 0)
> goto fail_poweroff;

^^^^ This goto is sign of a still existing ordering issue. so this patch is half-baked.

--
With Best Regards,
Andy Shevchenko



\
 
 \ /
  Last update: 2026-04-02 10:26    [W:0.064 / U:3.600 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and my Meterkast|Read the blog