Messages in this thread Patch in this message |  | | From | Julian Braha <> | | Subject | [RESEND PATCH] s390: fix dead defaults for S390_MODULES_SANITY_TEST and S390_UNWIND_SELFTEST | | Date | Tue, 14 Apr 2026 22:56:51 +0100 |
| |
These config options currently have unconditional defaults of 'n' from the def_tristate statement, which shadow the later default of 'KUNIT_ALL_TESTS', causing it to be dead code.
It looks to me like the commit 25d36a85c61b ("s390/test_unwind: convert to KUnit") added the KUNIT_ALL_TESTS default to S390_UNWIND_SELFTEST, but mistakenly didn't remove the previous 'n' default.
Then, the later commit 90c5318795ee ("s390/module: test loading modules with a lot of relocations") copied the Kconfig layout from S390_UNWIND_SELFTEST when adding the S390_MODULES_SANITY_TEST config option, without noticing the existing mistake.
This dead code was found by kconfirm, a static analysis tool for Kconfig.
Fixes: 25d36a85c61b ("s390/test_unwind: convert to KUnit") Fixes: 90c5318795ee ("s390/module: test loading modules with a lot of relocations") Signed-off-by: Julian Braha <julianbraha@gmail.com> --- arch/s390/Kconfig | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/arch/s390/Kconfig b/arch/s390/Kconfig index edc927d9e85a..1b3afe89cb00 100644 --- a/arch/s390/Kconfig +++ b/arch/s390/Kconfig @@ -999,9 +999,8 @@ config S390_MODULES_SANITY_TEST_HELPERS menu "Selftests" config S390_UNWIND_SELFTEST - def_tristate n + def_tristate KUNIT_ALL_TESTS depends on KUNIT - default KUNIT_ALL_TESTS prompt "Test unwind functions" help This option enables s390 specific stack unwinder testing kernel @@ -1023,9 +1022,8 @@ config S390_KPROBES_SANITY_TEST Say N if you are unsure. config S390_MODULES_SANITY_TEST - def_tristate n + def_tristate KUNIT_ALL_TESTS depends on KUNIT - default KUNIT_ALL_TESTS prompt "Enable s390 specific modules tests" select S390_MODULES_SANITY_TEST_HELPERS help -- 2.53.0
|  |