Messages in this thread |  | | From | Ping-Ke Shih <> | | Subject | RE: [PATCH] wifi: rtw89: fix wrong pci_get_drvdata type in AER handlers | | Date | Mon, 13 Apr 2026 06:06:48 +0000 |
| |
Ping-Ke Shih <pkshih@realtek.com> wrote: > Christos Longros <chris.longros@gmail.com> wrote: > > rtw89 stores an ieee80211_hw pointer via pci_set_drvdata() at probe > > time, but io_error_detected() and io_resume() retrieve it as a > > net_device pointer. This causes netif_device_detach/attach to > > operate on an ieee80211_hw struct, reading and writing at wrong > > offsets. The adjacent io_slot_reset() already does it correctly. > > > > Use ieee80211_stop_queues/wake_queues instead, consistent with > > every other queue stop/start path in the driver. > > > > Tested on RTL8852CE by calling the handlers from a test module > > before and after the fix. > > Could you share the "test module" you did? I'd like to know how to > test (simulate) the io error. > > >
I'd add a Fixes tag
Fixes: 16e3d93c6183 ("wifi: rtw89: pci: add PCI Express error handling")
> > Signed-off-by: Christos Longros <chris.longros@gmail.com> > > Acked-by: Ping-Ke Shih <pkshih@realtek.com> >
|  |