Messages in this thread |  | | From | Biju Das <> | | Subject | RE: [PATCH net-next] net: phy: call phy_init_hw() in phy resume path | | Date | Sat, 11 Apr 2026 14:32:17 +0000 |
| |
Hi Andrew,
> -----Original Message----- > From: Andrew Lunn <andrew@lunn.ch> > Sent: 11 April 2026 14:50 > Subject: Re: [PATCH net-next] net: phy: call phy_init_hw() in phy resume path > > > So, I question whether any of the functions in this driver actually > > have a valid reason to take phydev->lock - looks to me like a not very > > well written driver. > > > > In cases like this, I don't think we should make things more difficult > > in the core just because we have a lockdep splat when that can be > > avoided by killing off unnecessary locking. > > Agreed. This patchset should cleanup these locks.
OK, I will send a patch for removing these locks.
Cheers, Biju
|  |