Messages in this thread |  | | Date | Sat, 11 Apr 2026 15:50:13 +0200 | | From | Andrew Lunn <> | | Subject | Re: [PATCH net-next] net: phy: call phy_init_hw() in phy resume path |
| |
> So, I question whether any of the functions in this driver actually > have a valid reason to take phydev->lock - looks to me like a not > very well written driver. > > In cases like this, I don't think we should make things more > difficult in the core just because we have a lockdep splat when that > can be avoided by killing off unnecessary locking.
Agreed. This patchset should cleanup these locks.
We also need to look at lan937x_dsp_workaround(). I also don't see what that mutex lock/unlock is protecting. Accessing bank registers need to be protected, so doing one additional access within that should not need additional protection.
Andrew
|  |