Messages in this thread |  | | From | "Edgecombe, Rick P" <> | | Subject | Re: [PATCH v7 05/22] x86/virt/seamldr: Add a helper to retrieve P-SEAMLDR information | | Date | Sat, 11 Apr 2026 00:13:21 +0000 |
| |
On Tue, 2026-03-31 at 05:41 -0700, Chao Gao wrote: > P-SEAMLDR returns its information such as version number, in response to > the SEAMLDR.INFO SEAMCALL. > > This information is useful for userspace. For example, the admin can decide > which TDX module versions are compatible with the P-SEAMLDR according to > the P-SEAMLDR version.
We know what this will be used for, so it would have been nice to say it. Like:
This information is useful for userspace admins to decide.... Future changes will expose it to userspace...
Plus the remaining updates part is not hinted at.
> > Add a helper to retrieve P-SEAMLDR information in preparation for > exposing P-SEAMLDR version and other necessary information to userspace. > Export the new kAPI for use by tdx-host.ko. > > Note that there are two distinct P-SEAMLDR APIs with similar names: > > SEAMLDR.INFO: Returns a SEAMLDR_INFO structure containing SEAMLDR > information such as version and remaining updates. > > SEAMLDR.SEAMINFO: Returns a SEAMLDR_SEAMINFO structure containing SEAM > and system information such as Convertible Memory > Regions (CMRs) and number of CPUs and sockets. > > The former is used here. > > For details, see "Intel® Trust Domain Extensions - SEAM Loader (SEAMLDR) > Interface Specification". > > Signed-off-by: Chao Gao <chao.gao@intel.com> > Reviewed-by: Kai Huang <kai.huang@intel.com> > Reviewed-by: Kiryl Shutsemau (Meta) <kas@kernel.org> > Reviewed-by: Xiaoyao Li <xiaoyao.li@intel.com>
Either way,
Reviewed-by: Rick Edgecombe <rick.p.edgecombe@intel.com>
|  |