Messages in this thread |  | | Date | Fri, 10 Apr 2026 00:28:12 -0700 | | From | Ananthu C V <> | | Subject | Re: [PATCH v3] Add remoteproc PAS loader for SoCCP on Glymur DT |
| |
On Tue, Apr 07, 2026 at 01:41:33PM +0200, Konrad Dybcio wrote: > On 4/3/26 1:39 PM, Ananthu C V wrote: > > From: Sibi Sankar <sibi.sankar@oss.qualcomm.com> > > > > Signed-off-by: Sibi Sankar <sibi.sankar@oss.qualcomm.com> > > Co-developed-by: Ananthu C V <ananthu.cv@oss.qualcomm.com> > > Signed-off-by: Ananthu C V <ananthu.cv@oss.qualcomm.com> > > --- > > [...] > > > + remoteproc_soccp: remoteproc-soccp@d00000 { > > remoteproc-soccp@ ->remoteproc@
ack
> > + compatible = "qcom,glymur-soccp-pas", "qcom,kaanapali-soccp-pas"; > > + reg = <0x0 0x00d00000 0x0 0x200000>; > > + > > + interrupts-extended = <&intc GIC_SPI 167 IRQ_TYPE_EDGE_RISING>, > > + <&soccp_smp2p_in 0 IRQ_TYPE_EDGE_RISING>, > > + <&soccp_smp2p_in 1 IRQ_TYPE_EDGE_RISING>, > > + <&soccp_smp2p_in 2 IRQ_TYPE_EDGE_RISING>, > > + <&soccp_smp2p_in 3 IRQ_TYPE_EDGE_RISING>, > > + <&soccp_smp2p_in 9 IRQ_TYPE_EDGE_RISING>; > > + interrupt-names = "wdog", > > + "fatal", > > + "ready", > > + "handover", > > + "stop-ack", > > + "pong"; > > + > > + clocks = <&rpmhcc RPMH_CXO_CLK>; > > + clock-names = "xo"; > > + > > + power-domains = <&rpmhpd RPMHPD_CX>, > > + <&rpmhpd RPMHPD_MX>; > > + power-domain-names = "cx", > > + "mx"; > > + > > + memory-region = <&soccp_mem>, > > + <&soccpdtb_mem>; > > + > > + qcom,smem-states = <&soccp_smp2p_out 0>, > > + <&soccp_smp2p_out 8>; > > + qcom,smem-state-names = "stop", > > + "ping"; > > + > > + status = "disabled"; > > Let's drop this line, no one should desire to run a system without SoCCP
ack, that makes sense.
> > + > > + glink-edge { > > + interrupts-extended = <&ipcc IPCC_MPROC_SOCCP > > + IPCC_MPROC_SIGNAL_GLINK_QMP > > + IRQ_TYPE_EDGE_RISING>; > > + mboxes = <&ipcc IPCC_MPROC_SOCCP > > + IPCC_MPROC_SIGNAL_GLINK_QMP>; > > + qcom,remote-pid = <19>; > > + label = "soccp"; > > + > > + }; > > Stray \n above
noted, will fix.
> Konrad
Thanks for the review Konrad, will reflect the changes in the next revision.
Best, Ananthu
|  |