Messages in this thread |  | | Date | Mon, 9 Mar 2026 08:37:10 -0600 | | From | Mathieu Poirier <> | | Subject | Re: [PATCH] drivers: rpmsg: class_destroy() is deprecated |
| |
On Sun, Mar 08, 2026 at 03:08:49PM +0100, Jori Koolstra wrote: > The class_destroy() function documents that: > > Note, the pointer to be destroyed must have been created with a call > to class_create(). > > However, class_create() is deprecated. rpmsg already uses > class_register() but the class_destroy() calls should also be replaced > with class_unregister(). > > Link: https://lore.kernel.org/all/2023040244-duffel-pushpin-f738@gregkh/ > Signed-off-by: Jori Koolstra <jkoolstra@xs4all.nl> > --- > drivers/rpmsg/rpmsg_core.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) >
Applied - thanks, Mathieu
> diff --git a/drivers/rpmsg/rpmsg_core.c b/drivers/rpmsg/rpmsg_core.c > index 96964745065b..948541656950 100644 > --- a/drivers/rpmsg/rpmsg_core.c > +++ b/drivers/rpmsg/rpmsg_core.c > @@ -650,7 +650,7 @@ static int __init rpmsg_init(void) > ret = bus_register(&rpmsg_bus); > if (ret) { > pr_err("failed to register rpmsg bus: %d\n", ret); > - class_destroy(&rpmsg_class); > + class_unregister(&rpmsg_class); > } > return ret; > } > @@ -659,7 +659,7 @@ postcore_initcall(rpmsg_init); > static void __exit rpmsg_fini(void) > { > bus_unregister(&rpmsg_bus); > - class_destroy(&rpmsg_class); > + class_unregister(&rpmsg_class); > } > module_exit(rpmsg_fini); > > > base-commit: d466c332e106fe666d1e2f5a24d08e308bebbfa1 > -- > 2.53.0 >
|  |