lkml.org 
[lkml]   [2026]   [Mar]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v2 phy-next 24/24] MAINTAINERS: add regexes for linux-phy
On Sun, Mar 08, 2026 at 12:25:32PM -0700, Joe Perches wrote:
> On Sun, 2026-03-08 at 21:10 +0200, Vladimir Oltean wrote:
> > On Sun, Mar 08, 2026 at 11:40:44AM -0700, Joe Perches wrote:
> > > Perhaps if matching only the include uses:
> > > (/ is escaped because get_maintainer is stupid)
> > > something like:
> > >
> > > K: include\s*\<linux\/phy\/phy(?:-common-props|-provider)?\.h\>
>
> > Why is get_maintainer stupid?
>
> The get_maintainer code used to match keywords is
>
> foreach my $line (keys %keyword_hash) {
> if ($text =~ m/$keyword_hash{$line}/x) {
>
> so it seems the first / in the K: <foo> regex would terminate
> the match.
>
> It might have been better to use a different delimiter.
> Maybe:
>
> if ($text =~ m{$keyword_hash{$line}}/x

So why does it match in my example?

\
 
 \ /
  Last update: 2026-03-08 21:58    [from the cache]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and my Meterkast|Read the blog