Messages in this thread |  | | Date | Sun, 29 Mar 2026 19:42:23 +0200 | | From | Marco Felsch <> | | Subject | Re: [PATCH] dt-bindings: display: bridge: ldb: Require reg property only for i.MX6SX/8MP LDBs |
| |
Hi Liu,
sorry for not writting back earlier, the last weeks were quite busy.
On 26-03-29, Liu Ying wrote: > LDB's parent device could be a syscon which doesn't allow a reg property > to be present in it's child devices, e.g., NXP i.MX93 Media blk-ctrl > has a child device NXP i.MX93 Parallel Display Format Configuration(PDFC) > without a reg property(LDB is also a child device of the Media blk-ctrl). > To make the LDB schema be able to describe LDBs without the reg property > like i.MX93 LDB, require the reg property only for i.MX6SX/8MP LDBs.
NACK, we want to describe the HW and from HW PoV the LDB is and was always part of a syscon. This is the case for all SoCs i.MX6SX/8MP/93.
> Fixes: 8aa2f0ac08d3 ("dt-bindings: display: bridge: ldb: Add check for reg and reg-names")
Therefore I would just revert this patch completely.
Regards, Marco
> Signed-off-by: Liu Ying <victor.liu@nxp.com> > --- > .../bindings/display/bridge/fsl,ldb.yaml | 23 ++++++++++++++++------ > 1 file changed, 17 insertions(+), 6 deletions(-) > > diff --git a/Documentation/devicetree/bindings/display/bridge/fsl,ldb.yaml b/Documentation/devicetree/bindings/display/bridge/fsl,ldb.yaml > index 7f380879fffd..5f6dc2b11d7b 100644 > --- a/Documentation/devicetree/bindings/display/bridge/fsl,ldb.yaml > +++ b/Documentation/devicetree/bindings/display/bridge/fsl,ldb.yaml > @@ -28,6 +28,7 @@ properties: > const: ldb > > reg: > + minItems: 1 > maxItems: 2 > > reg-names: > @@ -68,7 +69,6 @@ required: > - compatible > - clocks > - ports > - - reg > > allOf: > - if: > @@ -83,12 +83,23 @@ allOf: > ports: > properties: > port@2: false > + > - if: > - not: > - properties: > - compatible: > - contains: > - const: fsl,imx6sx-ldb > + properties: > + compatible: > + contains: > + enum: > + - fsl,imx6sx-ldb > + - fsl,imx8mp-ldb > + then: > + required: > + - reg > + > + - if: > + properties: > + compatible: > + contains: > + const: fsl,imx8mp-ldb > then: > required: > - reg-names > > --- > base-commit: 3b058d1aeeeff27a7289529c4944291613b364e9 > change-id: 20260329-fsl_ldb_schema_fix-4fe01c42bff3 > > Best regards, > -- > Liu Ying <victor.liu@nxp.com> > >
-- #gernperDu #CallMeByMyFirstName
Pengutronix e.K. | | Steuerwalder Str. 21 | https://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-9 |
|  |