Messages in this thread Patch in this message |  | | From | Abel Vesa <> | | Date | Mon, 02 Mar 2026 10:34:46 +0200 | | Subject | [PATCH v2] phy: qcom: m31-eusb2: Make USB repeater optional |
| |
From: Wesley Cheng <wesley.cheng@oss.qualcomm.com>
A repeater is not required for the PHY to function. On systems with multiple PHY instances connected to a multi-port controller, some PHYs may be unconnected. All PHYs must still probe successfully even without attached repeaters, otherwise the controller probe fails.
So make it optional.
Signed-off-by: Wesley Cheng <wesley.cheng@oss.qualcomm.com> [abel.vesa@oss.qualcomm.com: commit re-worded to reflect actual reason] Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com> Reviewed-by: Bjorn Andersson <andersson@kernel.org> Signed-off-by: Abel Vesa <abel.vesa@oss.qualcomm.com> --- This has been sent initially by Wesley here: https://lore.kernel.org/all/20250920032108.242643-10-wesley.cheng@oss.qualcomm.com/
This is still needed, but for a different reason, so re-worded the commit message to reflect why. --- Changes in v2: - Picked up Bjorn's and Dmitry's R-b tags. - Fixed the subject line, as Bjorn suggested. - Link to v1: https://patch.msgid.link/20260227-phy-qcom-m31-eusb2-make-repeater-optional-v1-1-07a086bbaba4@oss.qualcomm.com --- drivers/phy/qualcomm/phy-qcom-m31-eusb2.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/phy/qualcomm/phy-qcom-m31-eusb2.c b/drivers/phy/qualcomm/phy-qcom-m31-eusb2.c index 95cd3175926d..70a81ab2482f 100644 --- a/drivers/phy/qualcomm/phy-qcom-m31-eusb2.c +++ b/drivers/phy/qualcomm/phy-qcom-m31-eusb2.c @@ -285,7 +285,7 @@ static int m31eusb2_phy_probe(struct platform_device *pdev) phy_set_drvdata(phy->phy, phy); - phy->repeater = devm_of_phy_get_by_index(dev, dev->of_node, 0); + phy->repeater = devm_phy_optional_get(dev, NULL); if (IS_ERR(phy->repeater)) return dev_err_probe(dev, PTR_ERR(phy->repeater), "failed to get repeater\n"); --- base-commit: 3fa5e5702a82d259897bd7e209469bc06368bf31 change-id: 20260227-phy-qcom-m31-eusb2-make-repeater-optional-621c8c1c0354 Best regards, -- Abel Vesa <abel.vesa@oss.qualcomm.com>
|  |