Messages in this thread |  | | Date | Tue, 10 Mar 2026 16:42:43 +0000 | | From | cristian_ci <> | | Subject | Re: [PATCH 3/6] arm64: dts: qcom: msm8953-flipkart-rimob: Enable display and GPU |
| |
On Tuesday, March 10th, 2026 at 12:28, Konrad Dybcio <konrad.dybcio@oss.qualcomm.com> wrote:
> On 3/8/26 4:01 PM, Dmitry Baryshkov wrote: > > On Sun, Mar 08, 2026 at 04:52:43PM +0100, Cristian Cozzolino via B4 Relay wrote: > >> From: Cristian Cozzolino <cristian_ci@protonmail.com> > >> > >> Add the description for the display panel found on this phone. > >> And with this done we can also enable the GPU and set the zap shader > >> firmware path. > >> > >> Signed-off-by: Cristian Cozzolino <cristian_ci@protonmail.com> > >> --- > >> .../arm64/boot/dts/qcom/msm8953-flipkart-rimob.dts | 80 ++++++++++++++++++++++ > >> 1 file changed, 80 insertions(+) > >> > >> + > >> +&mdss_dsi0 { > >> + vdda-supply = <&pm8953_s3>; > >> + vddio-supply = <&pm8953_l6>; > >> + > >> + pinctrl-0 = <&mdss_default>; > >> + pinctrl-1 = <&mdss_sleep>; > >> + pinctrl-names = "default", "sleep"; > > > > It might be better to move pinctrl nodes to the panel device, because > > they control the panel reset pin (rather than some kind if DSI-related > > pin). > > +1, perhaps let's rename that pin to panel_reset while at it
So, something like (plus related renaming in tlmm node):
panel: panel@0 { compatible = "novatek,nt35532"; reg = <0>;
backlight = <&pmi8950_wled>; reset-gpios = <&tlmm 61 GPIO_ACTIVE_LOW>; vsp-supply = <&lab>; vsn-supply = <&ibb>;
pinctrl-0 = <&panel_default>; pinctrl-1 = <&panel_reset>; pinctrl-names = "default", "reset";
port { panel_in: endpoint { remote-endpoint = <&mdss_dsi0_out>; }; }; }; this?
> Konrad >
Regards
|  |