Messages in this thread |  | | Date | Tue, 10 Mar 2026 16:20:38 +0000 | | From | cristian_ci <> | | Subject | Re: [PATCH 5/6] arm64: dts: qcom: msm8953-flipkart-rimob: Enable touchscreen |
| |
Cristian
Sent with Proton Mail secure email.
On Tuesday, March 10th, 2026 at 14:08, Konrad Dybcio <konrad.dybcio@oss.qualcomm.com> wrote:
> On 3/8/26 4:52 PM, Cristian Cozzolino via B4 Relay wrote: > > From: Cristian Cozzolino <cristian_ci@protonmail.com> > > > > This device uses a Goodix GT5688 touch controller, connected to i2c_3. > > Add it to the device tree. > > > > Signed-off-by: Cristian Cozzolino <cristian_ci@protonmail.com> > > --- > > .../arm64/boot/dts/qcom/msm8953-flipkart-rimob.dts | 32 ++++++++++++++++++++++ > > 1 file changed, 32 insertions(+) > > > > diff --git a/arch/arm64/boot/dts/qcom/msm8953-flipkart-rimob.dts b/arch/arm64/boot/dts/qcom/msm8953-flipkart-rimob.dts > > index 7b2849405462..709ea6fc9fbb 100644 > > --- a/arch/arm64/boot/dts/qcom/msm8953-flipkart-rimob.dts > > +++ b/arch/arm64/boot/dts/qcom/msm8953-flipkart-rimob.dts > > @@ -94,6 +94,31 @@ &hsusb_phy { > > status = "okay"; > > }; > > > > +&i2c_3 { > > + status = "okay"; > > + > > + touchscreen@5d { > > + compatible = "goodix,gt5688"; > > + reg = <0x5d>; > > + > > + interrupts-extended = <&tlmm 65 IRQ_TYPE_LEVEL_LOW>; > > interrupts *and* irq-gpios sounds wrong.. and I think the driver doesn't > even consume the former. Trying to read through some of that, I think > it's on purpose since the IRQ GPIO is repurposed for setting the I2C addr > (which nota bene doesn't match between the comment in that driver and this > submission - perhaps that's just a SKU difference) during the reset > sequence > > i.e., does the touch work any different if you drop the above?
Apparently, not. That works as expected.
> does /proc/interrupts differ?
When interrupts-extended is defined:
... 50: 318 0 0 0 0 0 0 0 msmgpio 65 Edge gt5688 ... 54: 3141 0 0 0 0 0 0 0 GIC-0 65 Level gpu-irq ...
Instead, when interrupts-extended is removed/commented out, I see just:
... 53: 2404 0 0 0 0 0 0 0 GIC-0 65 Level gpu-irq ...
> Konrad >
Regards
|  |