lkml.org 
[lkml]   [2026]   [Mar]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH 5/6] arm64: dts: qcom: msm8953-flipkart-rimob: Enable touchscreen
From
On 3/8/26 4:52 PM, Cristian Cozzolino via B4 Relay wrote:
> From: Cristian Cozzolino <cristian_ci@protonmail.com>
>
> This device uses a Goodix GT5688 touch controller, connected to i2c_3.
> Add it to the device tree.
>
> Signed-off-by: Cristian Cozzolino <cristian_ci@protonmail.com>
> ---
> .../arm64/boot/dts/qcom/msm8953-flipkart-rimob.dts | 32 ++++++++++++++++++++++
> 1 file changed, 32 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/qcom/msm8953-flipkart-rimob.dts b/arch/arm64/boot/dts/qcom/msm8953-flipkart-rimob.dts
> index 7b2849405462..709ea6fc9fbb 100644
> --- a/arch/arm64/boot/dts/qcom/msm8953-flipkart-rimob.dts
> +++ b/arch/arm64/boot/dts/qcom/msm8953-flipkart-rimob.dts
> @@ -94,6 +94,31 @@ &hsusb_phy {
> status = "okay";
> };
>
> +&i2c_3 {
> + status = "okay";
> +
> + touchscreen@5d {
> + compatible = "goodix,gt5688";
> + reg = <0x5d>;
> +
> + interrupts-extended = <&tlmm 65 IRQ_TYPE_LEVEL_LOW>;

interrupts *and* irq-gpios sounds wrong.. and I think the driver doesn't
even consume the former. Trying to read through some of that, I think
it's on purpose since the IRQ GPIO is repurposed for setting the I2C addr
(which nota bene doesn't match between the comment in that driver and this
submission - perhaps that's just a SKU difference) during the reset
sequence

i.e., does the touch work any different if you drop the above?
does /proc/interrupts differ?

Konrad

\
 
 \ /
  Last update: 2026-03-10 15:50    [from the cache]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and my Meterkast|Read the blog