Messages in this thread Patch in this message |  | | Date | Fri, 9 Jan 2026 14:18:14 +0100 | | From | Andrew Lunn <> | | Subject | Re: [PATCH net-next 3/5] net: phy: realtek: reunify C22 and C45 drivers |
| |
On Fri, Jan 09, 2026 at 03:03:33AM +0000, Daniel Golle wrote: > Reunify the split C22/C45 drivers for the RTL8221B-VB-CG 2.5Gbps and > RTL8221B-VM-CG 2.5Gbps PHYs back into a single driver. > This is possible now by using all the driver operations previously used > by the C45 driver, as transparent access to all MMDs including > MDIO_MMD_VEND2 is now possible also over Clause-22 MDIO. > > Signed-off-by: Daniel Golle <daniel@makrotopia.org> > --- > drivers/net/phy/realtek/realtek_main.c | 72 ++++++-------------------- > 1 file changed, 16 insertions(+), 56 deletions(-) > > diff --git a/drivers/net/phy/realtek/realtek_main.c b/drivers/net/phy/realtek/realtek_main.c > index 886694ff995f6..d07d60bc1ce34 100644 > --- a/drivers/net/phy/realtek/realtek_main.c > +++ b/drivers/net/phy/realtek/realtek_main.c > @@ -1879,28 +1879,18 @@ static int rtl8221b_match_phy_device(struct phy_device *phydev, > return phydev->phy_id == RTL_8221B && rtlgen_supports_mmd(phydev); > } > > -static int rtl8221b_vb_cg_c22_match_phy_device(struct phy_device *phydev, > - const struct phy_driver *phydrv) > +static int rtl8221b_vb_cg_match_phy_device(struct phy_device *phydev, > + const struct phy_driver *phydrv) > { > - return rtlgen_is_c45_match(phydev, RTL_8221B_VB_CG, false); > + return rtlgen_is_c45_match(phydev, RTL_8221B_VB_CG, true) || > + rtlgen_is_c45_match(phydev, RTL_8221B_VB_CG, false);
Are there any calls left to rtlgen_is_c45_match() which don't || true and false? If not, maybe add another patch which removes the bool parameter?
Andrew
|  |