lkml.org 
[lkml]   [2025]   [Sep]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
From
Date
Subject[PATCH v6 8/9] coresight: tmc: integrate byte-cntr's read_ops with sysfs file_ops
Add code logic to invoke byte-cntr's sysfs_read_ops if the byte-cntr
is enabled.

Signed-off-by: Jie Gan <jie.gan@oss.qualcomm.com>
---
drivers/hwtracing/coresight/coresight-tmc-core.c | 53 +++++++++++++++++++++++-
1 file changed, 52 insertions(+), 1 deletion(-)

diff --git a/drivers/hwtracing/coresight/coresight-tmc-core.c b/drivers/hwtracing/coresight/coresight-tmc-core.c
index ccb177d953b9..2895a9b431c3 100644
--- a/drivers/hwtracing/coresight/coresight-tmc-core.c
+++ b/drivers/hwtracing/coresight/coresight-tmc-core.c
@@ -31,6 +31,7 @@

#include "coresight-priv.h"
#include "coresight-tmc.h"
+#include "coresight-ctcu.h"

DEFINE_CORESIGHT_DEVLIST(etb_devs, "tmc_etb");
DEFINE_CORESIGHT_DEVLIST(etf_devs, "tmc_etf");
@@ -228,15 +229,47 @@ static int tmc_prepare_crashdata(struct tmc_drvdata *drvdata)
return 0;
}

+/* Return the byte-cntr's sysfs_read_ops if in use */
+static const struct sysfs_read_ops *tmc_get_byte_cntr_sysfs_ops(struct tmc_drvdata *drvdata)
+{
+ struct ctcu_byte_cntr *byte_cntr_data;
+ struct ctcu_drvdata *ctcu_drvdata;
+ struct coresight_device *helper;
+ int port;
+
+ helper = coresight_get_helper(drvdata->csdev, CORESIGHT_DEV_SUBTYPE_HELPER_CTCU);
+ if (!helper)
+ return NULL;
+
+ port = coresight_get_in_port_dest(drvdata->csdev, helper);
+ if (port < 0)
+ return NULL;
+
+ ctcu_drvdata = dev_get_drvdata(helper->dev.parent);
+ byte_cntr_data = &ctcu_drvdata->byte_cntr_data[port];
+ if (byte_cntr_data && byte_cntr_data->thresh_val)
+ return ctcu_drvdata->byte_cntr_sysfs_read_ops;
+
+ return NULL;
+}
+
static int tmc_read_prepare(struct tmc_drvdata *drvdata)
{
+ const struct sysfs_read_ops *byte_cntr_sysfs_read_ops;
int ret = 0;

+ byte_cntr_sysfs_read_ops = tmc_get_byte_cntr_sysfs_ops(drvdata);
+ if (byte_cntr_sysfs_read_ops) {
+ ret = byte_cntr_sysfs_read_ops->read_prepare(drvdata);
+ goto out;
+ }
+
if (drvdata->sysfs_ops)
ret = drvdata->sysfs_ops->read_prepare(drvdata);
else
ret = -EINVAL;

+out:
if (!ret)
dev_dbg(&drvdata->csdev->dev, "TMC read start\n");

@@ -245,13 +278,21 @@ static int tmc_read_prepare(struct tmc_drvdata *drvdata)

static int tmc_read_unprepare(struct tmc_drvdata *drvdata)
{
+ const struct sysfs_read_ops *byte_cntr_sysfs_read_ops;
int ret = 0;

+ byte_cntr_sysfs_read_ops = tmc_get_byte_cntr_sysfs_ops(drvdata);
+ if (byte_cntr_sysfs_read_ops) {
+ ret = byte_cntr_sysfs_read_ops->read_unprepare(drvdata);
+ goto out;
+ }
+
if (drvdata->sysfs_ops)
ret = drvdata->sysfs_ops->read_unprepare(drvdata);
else
ret = -EINVAL;

+out:
if (!ret)
dev_dbg(&drvdata->csdev->dev, "TMC read end\n");

@@ -277,6 +318,12 @@ static int tmc_open(struct inode *inode, struct file *file)
static ssize_t tmc_get_sysfs_trace(struct tmc_drvdata *drvdata, loff_t pos, size_t len,
char **bufpp)
{
+ const struct sysfs_read_ops *byte_cntr_sysfs_read_ops;
+
+ byte_cntr_sysfs_read_ops = tmc_get_byte_cntr_sysfs_ops(drvdata);
+ if (byte_cntr_sysfs_read_ops)
+ return byte_cntr_sysfs_read_ops->get_trace_data(drvdata, pos, len, bufpp);
+
if (drvdata->sysfs_ops)
return drvdata->sysfs_ops->get_trace_data(drvdata, pos, len, bufpp);

@@ -300,7 +347,11 @@ static ssize_t tmc_read(struct file *file, char __user *data, size_t len,
return -EFAULT;
}

- *ppos += actual;
+ if (drvdata->reading_node)
+ drvdata->reading_node->pos += actual;
+ else
+ *ppos += actual;
+
dev_dbg(&drvdata->csdev->dev, "%zu bytes copied\n", actual);

return actual;
--
2.34.1


\
 
 \ /
  Last update: 2025-09-08 04:05    [from the cache]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and my Meterkast|Read the blog