lkml.org 
[lkml]   [2025]   [Sep]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH net-next v9 2/5] net: spacemit: Add K1 Ethernet MAC
From

On 9/6/25 07:59, Jakub Kicinski wrote:
> On Sat, 6 Sep 2025 00:35:37 +0800 Vivian Wang wrote:
>>>> On a closer look, these counters in ndev->stats seems to be redundant
>>>> with the hardware-tracked statistics, so maybe I should just not bother
>>>> with updating ndev->stats. Does that make sense?
>>> For rx/tx packets/bytes I think that makes sense.
>>> But what about rx/tx drops?
>> Right... but tstats doesn't have *_dropped. It seems that tx_dropped and
>> rx_dropped are considered "slow path" for real devices. It makes sense
>> to me that those should be very rare.
> Pretty sure Simon meant the per-cpu netdev stats in general.
> There are three types of them, if you need drops I think you
> probably want dstats. Take a look.

Thank you, I will look into this.


\
 
 \ /
  Last update: 2025-09-06 03:47    [from the cache]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and my Meterkast|Read the blog