Messages in this thread |  | | Date | Sat, 6 Sep 2025 09:46:31 +0800 | | Subject | Re: [PATCH net-next v9 2/5] net: spacemit: Add K1 Ethernet MAC | | From | Vivian Wang <> |
| |
On 9/6/25 07:59, Jakub Kicinski wrote: > On Sat, 6 Sep 2025 00:35:37 +0800 Vivian Wang wrote: >>>> On a closer look, these counters in ndev->stats seems to be redundant >>>> with the hardware-tracked statistics, so maybe I should just not bother >>>> with updating ndev->stats. Does that make sense? >>> For rx/tx packets/bytes I think that makes sense. >>> But what about rx/tx drops? >> Right... but tstats doesn't have *_dropped. It seems that tx_dropped and >> rx_dropped are considered "slow path" for real devices. It makes sense >> to me that those should be very rare. > Pretty sure Simon meant the per-cpu netdev stats in general. > There are three types of them, if you need drops I think you > probably want dstats. Take a look.
Thank you, I will look into this.
|  |