Messages in this thread |  | | Date | Fri, 5 Sep 2025 11:04:14 +0530 | | From | Neeraj Kumar <> | | Subject | Re: [PATCH V2 03/20] nvdimm/namespace_label: Add namespace label changes as per CXL LSA v2.1 |
| |
On 19/08/25 02:36PM, Ira Weiny wrote: >Neeraj Kumar wrote: >> CXL 3.2 Spec mentions CXL LSA 2.1 Namespace Labels at section 9.13.2.5 >> Modified __pmem_label_update function using setter functions to update >> namespace label as per CXL LSA 2.1 >> >> Signed-off-by: Neeraj Kumar <s.neeraj@samsung.com> > >[snip] > >> >> +static inline void nsl_set_type(struct nvdimm_drvdata *ndd, >> + struct nd_namespace_label *ns_label) >> +{ >> + uuid_t tmp; >> + >> + if (ndd->cxl) { >> + uuid_parse(CXL_NAMESPACE_UUID, &tmp); >> + export_uuid(ns_label->cxl.type, &tmp); > >One more thing why can't uuid_parse put the UUID directly into type?
Thanks Ira for your suggestion. I have used because of uuid_parse() and export_uuid() signature difference. But yes we can only use uuid_parse() using typecasting. I will modify it in next patch-set.
> >I think this is done at least 1 other place. > >Ira
Sure, I will fix it at the other place as well.
Regards, Neeraj
|  |