Messages in this thread |  | | Date | Thu, 4 Sep 2025 10:18:32 -0400 | | From | Frank Li <> | | Subject | Re: [PATCH v5 4/9] phy: phy-can-transceiver: Drop the gpio desc check |
| |
On Thu, Sep 04, 2025 at 04:36:47PM +0800, Peng Fan wrote: > gpiod_set_value_cansleep has an internal check on gpio_desc using > 'VALIDATE_DESC(desc)', the check before invoking gpiod_set_value_cansleep > could be removed. > > Signed-off-by: Peng Fan <peng.fan@nxp.com>
Reviewed-by: Frank Li <Frank.Li@nxp.com>
> --- > drivers/phy/phy-can-transceiver.c | 12 ++++-------- > 1 file changed, 4 insertions(+), 8 deletions(-) > > diff --git a/drivers/phy/phy-can-transceiver.c b/drivers/phy/phy-can-transceiver.c > index f06b1df76ada023f432dce892c3346f45397ab54..b7d75a78d9242e2003660a87d2d4c9f784aea523 100644 > --- a/drivers/phy/phy-can-transceiver.c > +++ b/drivers/phy/phy-can-transceiver.c > @@ -46,10 +46,8 @@ static int can_transceiver_phy_power_on(struct phy *phy) > return ret; > } > } > - if (can_transceiver_phy->standby_gpio) > - gpiod_set_value_cansleep(can_transceiver_phy->standby_gpio, 0); > - if (can_transceiver_phy->enable_gpio) > - gpiod_set_value_cansleep(can_transceiver_phy->enable_gpio, 1); > + gpiod_set_value_cansleep(can_transceiver_phy->standby_gpio, 0); > + gpiod_set_value_cansleep(can_transceiver_phy->enable_gpio, 1); > > return 0; > } > @@ -59,10 +57,8 @@ static int can_transceiver_phy_power_off(struct phy *phy) > { > struct can_transceiver_phy *can_transceiver_phy = phy_get_drvdata(phy); > > - if (can_transceiver_phy->standby_gpio) > - gpiod_set_value_cansleep(can_transceiver_phy->standby_gpio, 1); > - if (can_transceiver_phy->enable_gpio) > - gpiod_set_value_cansleep(can_transceiver_phy->enable_gpio, 0); > + gpiod_set_value_cansleep(can_transceiver_phy->standby_gpio, 1); > + gpiod_set_value_cansleep(can_transceiver_phy->enable_gpio, 0); > if (can_transceiver_phy->priv->mux_state) > mux_state_deselect(can_transceiver_phy->priv->mux_state); > > > -- > 2.37.1 >
|  |