lkml.org 
[lkml]   [2025]   [Sep]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v3 2/3] cpufreq: powernow: Use int type to store negative error codes
$Subject is incorrect.

On 02-09-25, 19:45, Qianfeng Rong wrote:
> In powernow_decode_bios(), the 'ret' variable stores either negative error
> codes or zero returned by get_ranges(), so it needs to be changed to int
> type.

You don't need to mention this now. You are making a different change.

> However, since the 'ret' variable is only used once and can be
> simplified to 'return get_ranges()', it is better to remove the 'ret'
> variable.
>
> Signed-off-by: Qianfeng Rong <rongqianfeng@vivo.com>
> drivers/cpufreq/powernow-k7.c | 4 +---

There should be a `---` line in between these two statements, you have
corrupted your patch somehow.

> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/cpufreq/powernow-k7.c b/drivers/cpufreq/powernow-k7.c
> index 31039330a3ba..72430c3c5500 100644
> --- a/drivers/cpufreq/powernow-k7.c
> +++ b/drivers/cpufreq/powernow-k7.c
> @@ -451,7 +451,6 @@ static int powernow_decode_bios(int maxfid, int startvid)
> unsigned int i, j;
> unsigned char *p;
> unsigned int etuple;
> - unsigned int ret;
>
> etuple = cpuid_eax(0x80000001);
>
> @@ -500,8 +499,7 @@ static int powernow_decode_bios(int maxfid, int startvid)
> (startvid == pst->startvid)) {
> print_pst_entry(pst, j);
> p = (char *)pst + sizeof(*pst);
> - ret = get_ranges(p);
> - return ret;
> + return get_ranges(p);
> } else {
> unsigned int k;
> p = (char *)pst + sizeof(*pst);
> --
> 2.34.1

--
viresh

\
 
 \ /
  Last update: 2025-09-03 06:15    [from the cache]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and my Meterkast|Read the blog