Messages in this thread |  | | Date | Wed, 3 Sep 2025 15:59:01 +0200 | | Subject | Re: [PATCH v5 02/11] drm/fourcc: Add DRM_FORMAT_XV15/XV20 | | From | "Sagar, Vishal" <> |
| |
Hi Tomi,
Thanks for the patch.
On 4/25/2025 1:01 PM, Tomi Valkeinen wrote: > Add two new pixel formats: > > DRM_FORMAT_XV15 ("XV15") > DRM_FORMAT_XV20 ("XV20") > > The formats are 2 plane 10 bit per component YCbCr, with the XV15 2x2 > subsampled whereas XV20 is 2x1 subsampled. > > Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> > Signed-off-by: Tomi Valkeinen <tomi.valkeinen@ideasonboard.com> > --- > drivers/gpu/drm/drm_fourcc.c | 6 ++++++ > include/uapi/drm/drm_fourcc.h | 8 ++++++++ > 2 files changed, 14 insertions(+) > > diff --git a/drivers/gpu/drm/drm_fourcc.c b/drivers/gpu/drm/drm_fourcc.c > index 2f5781f5dcda..e101d1b99aeb 100644 > --- a/drivers/gpu/drm/drm_fourcc.c > +++ b/drivers/gpu/drm/drm_fourcc.c > @@ -346,6 +346,12 @@ const struct drm_format_info *__drm_format_info(u32 format) > { .format = DRM_FORMAT_P030, .depth = 0, .num_planes = 2, > .char_per_block = { 4, 8, 0 }, .block_w = { 3, 3, 0 }, .block_h = { 1, 1, 0 }, > .hsub = 2, .vsub = 2, .is_yuv = true}, > + { .format = DRM_FORMAT_XV15, .depth = 0, .num_planes = 2, > + .char_per_block = { 4, 8, 0 }, .block_w = { 3, 3, 0 }, .block_h = { 1, 1, 0 }, > + .hsub = 2, .vsub = 2, .is_yuv = true }, > + { .format = DRM_FORMAT_XV20, .depth = 0, .num_planes = 2, > + .char_per_block = { 4, 8, 0 }, .block_w = { 3, 3, 0 }, .block_h = { 1, 1, 0 }, > + .hsub = 2, .vsub = 1, .is_yuv = true }, > }; > > unsigned int i; > diff --git a/include/uapi/drm/drm_fourcc.h b/include/uapi/drm/drm_fourcc.h > index 81202a50dc9e..1247b814bd66 100644 > --- a/include/uapi/drm/drm_fourcc.h > +++ b/include/uapi/drm/drm_fourcc.h > @@ -304,6 +304,14 @@ extern "C" { > #define DRM_FORMAT_RGB565_A8 fourcc_code('R', '5', 'A', '8') > #define DRM_FORMAT_BGR565_A8 fourcc_code('B', '5', 'A', '8') > > +/* > + * 2 plane 10 bit per component YCrCb > + * index 0 = Y plane, [31:0] x:Y2:Y1:Y0 2:10:10:10 little endian > + * index 1 = Cb:Cr plane, [63:0] x:Cr2:Cb2:Cr1:x:Cb1:Cr0:Cb0 2:10:10:10:2:10:10:10 little endian > + */ > +#define DRM_FORMAT_XV15 fourcc_code('X', 'V', '1', '5') /* 2x2 subsampled Cr:Cb plane 2:10:10:10 */ > +#define DRM_FORMAT_XV20 fourcc_code('X', 'V', '2', '0') /* 2x1 subsampled Cr:Cb plane 2:10:10:10 */ > + > /* > * 2 plane YCbCr > * index 0 = Y plane, [7:0] Y >
This looks good to me. Please feel free to add -
Reviewed-by: Vishal Sagar <vishal.sagar@amd.com>
Regards Vishal Sagar
|  |