Messages in this thread |  | | Date | Wed, 3 Sep 2025 16:28:46 +0300 | | From | Vladimir Oltean <> | | Subject | Re: [PATCH] net: dsa: dsa_loop: use int type to store negative error codes |
| |
On Wed, Sep 03, 2025 at 08:34:03PM +0800, Qianfeng Rong wrote: > Change the 'ret' variable in dsa_loop_init() from unsigned int to int, as > it needs to store either negative error codes or zero returned by > mdio_driver_register(). > > Storing the negative error codes in unsigned type, doesn't cause an issue > at runtime but can be confusing. Additionally, assigning negative error > codes to unsigned type may trigger a GCC warning when the -Wsign-conversion > flag is enabled. > > No effect on runtime. > > Signed-off-by: Qianfeng Rong <rongqianfeng@vivo.com> > ---
Reviewed-by: Vladimir Oltean <olteanv@gmail.com>
|  |