Messages in this thread |  | | Date | Tue, 2 Sep 2025 06:19:09 +0800 | | From | Inochi Amaoto <> | | Subject | Re: [PATCH v2] PCI/MSI: Check MSI_FLAG_PCI_MSI_MASK_PARENT in cond_[startup|shutdown]_parent() |
| |
On Mon, Sep 01, 2025 at 03:56:04PM +0100, Jon Hunter wrote: > > On 01/09/2025 14:30, Anders Roxell wrote: > > On Thu, 28 Aug 2025 at 01:10, Inochi Amaoto <inochiama@gmail.com> wrote: > > > > > > For msi controller that only supports MSI_FLAG_PCI_MSI_MASK_PARENT, > > > the newly added callback irq_startup() and irq_shutdown() for > > > pci_msi[x]_template will not unmask/mask the interrupt when startup/ > > > shutdown the interrupt. This will prevent the interrupt from being > > > enabled/disabled normally. > > > > > > Add the missing check for MSI_FLAG_PCI_MSI_MASK_PARENT in the > > > cond_[startup|shutdown]_parent(). So the interrupt can be normally > > > unmasked/masked if it does not support MSI_FLAG_PCI_MSI_MASK_PARENT. > > > > > > Fixes: 54f45a30c0d0 ("PCI/MSI: Add startup/shutdown for per device domains") > > > Reported-by: Linux Kernel Functional Testing <lkft@linaro.org> > > > Closes: https://lore.kernel.org/regressions/aK4O7Hl8NCVEMznB@monster/ > > > Reported-by: Nathan Chancellor <nathan@kernel.org> > > > Closes: https://lore.kernel.org/regressions/20250826220959.GA4119563@ax162/ > > > Reported-by: Wei Fang <wei.fang@nxp.com> > > > Closes: https://lore.kernel.org/all/20250827093911.1218640-1-wei.fang@nxp.com/ > > > Signed-off-by: Inochi Amaoto <inochiama@gmail.com> > > > Tested-by: Nathan Chancellor <nathan@kernel.org> > > > Tested-by: Linux Kernel Functional Testing <lkft@linaro.org> > > > Tested-by: Jon Hunter <jonathanh@nvidia.com> > > > Acked-by: Bjorn Helgaas <bhelgaas@google.com> > > > > Any updates on this? It pretty much breaks testing on linux-next for ARM. > > Also does it make sense to squash this fix with the original patch? It > caused boot failures on at least 3 of our boards and so could impact the > ability to bisect other issues. >
As Thomas has taken the original series, I think it is hard to do a squash. I will ping Thomas to see if he can take it.
Regards, Inochi
|  |