Messages in this thread |  | | Date | Mon, 1 Sep 2025 15:37:25 +0900 | | Subject | Re: [PATCH RFC v3 06/15] md/raid0: convert raid0_handle_discard() to use bio_submit_split_bioset() | | From | Damien Le Moal <> |
| |
On 9/1/25 12:32 PM, Yu Kuai wrote: > From: Yu Kuai <yukuai3@huawei.com> > > Unify bio split code, and prepare to fix disordered split IO
Missing the period at the end of the above sentence.
> > Noted commit 319ff40a5427 ("md/raid0: Fix performance regression for large > sequential writes") already fix disordered split IO by converting bio to > underlying disks before submit_bio_noacct(), with the respect > md_submit_bio() already split by sectors, and raid0_make_request() will > split at most once for unaligned IO. This is a bit hacky and we'll convert > this to solution in general later.
I do not see how this is relevant to this patch. The patch is a simple straightforward conversion of hard-coded BIO split to using bio_submit_split_bioset(). So I would just say that.
> Signed-off-by: Yu Kuai <yukuai3@huawei.com>
With the above addressed, this looks OK to me.
Reviewed-by: Damien Le Moal <dlemoal@kernel.org>
-- Damien Le Moal Western Digital Research
|  |