| Date | Mon, 25 Aug 2025 20:32:41 +0300 | | From | Dmitry Baryshkov <> | | Subject | Re: [PATCH v3 07/38] drm/msm/dp: allow dp_ctrl stream APIs to use any panel passed to it |
| |
On Mon, Aug 25, 2025 at 10:15:53PM +0800, Yongxing Mou wrote: > From: Abhinav Kumar <quic_abhinavk@quicinc.com> > > Currently, the dp_ctrl stream APIs operate on their own dp_panel > which is cached inside the dp_ctrl's private struct. However with MST, > the cached panel represents the fixed link and not the sinks which > are hotplugged. Allow the stream related APIs to work on the panel > which is passed to them rather than the cached one. For SST cases, > this shall continue to use the cached dp_panel.
cached -> stored
I think that for MST case we should not be using the msm_dp_panel for the link handling at all. Does that make sense or would it require too big refactoring?
> > Signed-off-by: Abhinav Kumar <quic_abhinavk@quicinc.com> > Signed-off-by: Yongxing Mou <yongxing.mou@oss.qualcomm.com> > --- > drivers/gpu/drm/msm/dp/dp_ctrl.c | 21 +++++++++++---------- > drivers/gpu/drm/msm/dp/dp_ctrl.h | 2 +- > drivers/gpu/drm/msm/dp/dp_display.c | 2 +- > 3 files changed, 13 insertions(+), 12 deletions(-) >
The patch LGTM.
-- With best wishes Dmitry
|