lkml.org 
[lkml]   [2025]   [May]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v2 2/6] ASoC: aoa: Use helper function for_each_child_of_node_scoped()
From
Date
On Mon, 2025-05-26 at 16:12 +0800, Ai Chao wrote:
> Hi Johannes:
>
> > > "simplifies the code" is no need to callof_node_put() .
> > Fair. Except that's not what you _actually_ changed here. Like I said,
> > either it's buggy before or after.
> >
> In the function i2sbus_probe, it not return a struct device_node, so , I
> think function for_each_child_of_node_scoped is better than
> for_each_child_of_node.

You still haven't explained why it's even correct.

johannes

\
 
 \ /
  Last update: 2025-05-26 10:15    [from the cache]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and my Meterkast|Read the blog