Messages in this thread |  | | Date | Fri, 23 May 2025 11:32:40 +0300 | | From | Dmitry Baryshkov <> | | Subject | Re: [PATCH v2 2/2] soc: qcom: fix endianness for QMI header |
| |
On Fri, May 23, 2025 at 07:57:50AM +0200, Alexander Wilhelm wrote: > Am Thu, May 22, 2025 at 10:09:13PM +0300 schrieb Dmitry Baryshkov: > > On Thu, May 22, 2025 at 04:35:30PM +0200, Alexander Wilhelm wrote: > > > The members of QMI header have to be swapped on big endian platforms. Use > > > __le16 types instead of u16 ones. > > > > > > Signed-off-by: Alexander Wilhelm <alexander.wilhelm@westermo.com> > > > --- > > > drivers/soc/qcom/qmi_encdec.c | 6 +++--- > > > drivers/soc/qcom/qmi_interface.c | 6 +++--- > > > include/linux/soc/qcom/qmi.h | 6 +++--- > > > 3 files changed, 9 insertions(+), 9 deletions(-) > > > > Just out of curiosity, is there a usecase for running QMI helpers on BE > > platforms? > > I'm not familiar with modems, but the wireless drivers ath11k and ath12k use the > QMI helpers while transferring the firmware and boardfile to the module. As an > example here is the log by probing ath12k device on big endian without a patch: > > ath12k_pci 0001:01:00.0: BAR 0: assigned [mem 0xc00000000-0xc001fffff 64bit] > ath12k_pci 0001:01:00.0: MSI vectors: 1 > ath12k_pci 0001:01:00.0: Hardware name: qcn9274 hw2.0 > ath12k_pci 0001:01:00.0: FW Ind register request failed, result: 256, err: 512 > ath12k_pci 0001:01:00.0: qmi failed to send FW indication QMI:-22 > > Similar behavior is seen with ath11k drivers.
Ack, thanks. -- With best wishes Dmitry
|  |