lkml.org 
[lkml]   [2025]   [May]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH 01/18] media: coda: Add print if irq isn't present
From
Date
Le vendredi 23 mai 2025 à 19:40 -0400, Nicolas Dufresne a écrit :
> Hi,
>
> Le vendredi 14 mars 2025 à 18:29 +0300, Sergey Khimich a écrit :
> > From: Vladimir Yakovlev <vovchkir@gmail.com>
> >
> > Use dev_err_probe for print and return error if irq isn't present
> >
> > Co-developed-by: Sergey Khimich <serghox@gmail.com>
> > Signed-off-by: Sergey Khimich <serghox@gmail.com>
> > Signed-off-by: Vladimir Yakovlev <vovchkir@gmail.com>
>
> Reviewed-by: Nicolas Dufresne <nicolas.dufresne@collabora.com>

Please don't forget to move Vladimir SoB first in v2, while adding
this Rb. This applies to most of your patches.

Nicolas

>
> > ---
> >  drivers/media/platform/chips-media/coda/coda-common.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/media/platform/chips-media/coda/coda-common.c b/drivers/media/platform/chips-media/coda/coda-
> > common.c
> > index 289a076c3bcc..84b9b75b382e 100644
> > --- a/drivers/media/platform/chips-media/coda/coda-common.c
> > +++ b/drivers/media/platform/chips-media/coda/coda-common.c
> > @@ -3178,7 +3178,7 @@ static int coda_probe(struct platform_device *pdev)
> >   if (irq < 0)
> >   irq = platform_get_irq(pdev, 0);
> >   if (irq < 0)
> > - return irq;
> > + return dev_err_probe(&pdev->dev, irq, "Failed to get irq 0 (bit)\n");
> >  
> >   ret = devm_request_irq(&pdev->dev, irq, coda_irq_handler, 0,
> >          CODA_NAME "-video", dev);

\
 
 \ /
  Last update: 2025-05-24 01:44    [from the cache]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and my Meterkast|Read the blog