lkml.org 
[lkml]   [2025]   [May]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRE: [PATCH v1 2/2] ASoC: codecs: add support for ES8375
Date
> > +static const struct snd_kcontrol_new es8375_snd_controls[] = {
> > + SOC_SINGLE_TLV("ADC OSR GAIN Volume", ES8375_ADC_OSR_GAIN,
> > + ADC_OSR_GAIN_SHIFT_0, ES8375_ADC_OSR_GAIN_MAX, 0,
> > + es8375_adc_osr_gain_tlv),
>
> Probably just ADC OSR Volume.
>
> > + SOC_SINGLE_TLV("DMIC Gain Volume", ES8375_ADC1,
> > + DMIC_GAIN_SHIFT_2, ES8375_DMIC_GAIN_MAX,
> > + 0, es8375_adc_dmic_volume_tlv),
>
> Same here.
>
> > + SOC_SINGLE("ADC Automute Enable", ES8375_ADC_AUTOMUTE,
> > + ADC_AUTOMUTE_SHIFT_7, 1, 0),
> > +
> > + SOC_SINGLE("DAC DSM Mute", ES8375_DAC1, DAC_DSMMUTE_SHIFT_7, 1, 0),
> > + SOC_SINGLE("DAC DEM Mute", ES8375_DAC1, DAC_DEMMUTE_SHIFT_6, 1, 0),
>
> > + SOC_SINGLE("DAC Automute Enable", ES8375_DAC_AUTOMUTE1,
> > + DAC_AUTOMUTE_EN_SHIFT_7, 1, 0),
>
> These are all on/off switches so should be Switch.
>
> > + SOC_SINGLE_TLV("DAC Automute Attenuation", ES8375_DAC_AUTOMUTE,
> > + DAC_AUTOMUTE_ATTN_SHIFT_0, ES8375_DAC_AUTOMUTE_ATTN_MAX,
> > + 0, es8375_dac_automute_attn_tlv),
>
> This is also a Volume ("DAC Automute Volume").

I'll modify these control-name.

> > + if (es8375->mclk_src == ES8375_BCLK_PIN) {
> > + if (es8375->mastermode) {
> > + dev_err(component->dev, "no mclk, cannot as master\n");
> > + return -EINVAL;
> > + }
>
> Still got the outdated clocking terminology here.

I'll delete it

\
 
 \ /
  Last update: 2025-05-23 04:36    [from the cache]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and my Meterkast|Read the blog