lkml.org 
[lkml]   [2025]   [May]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] net: hns3: Add error handling for VLAN filter hardwareconfiguration
On Tue, May 20, 2025 at 09:14:28AM +0800, Wentao Liang wrote:
> > Are there any real functional problems?
> > Would you please tell me your test cases? I'm going to try to reproduce the problem.
>
> Hi,
>
> I found this problem by static analysis and manual auditing. I believe there should be add a check just like the other call of hclge_set_vlan_filter_hw(). If the check is useless, could you please tell me the detailed reason.

Thanks,

I think it would be useful for the patch description to state
that the problem was found using static analysis.

But let's wait for more feedback from Jijie on if this
check is, at least theoretically, required.

\
 
 \ /
  Last update: 2025-05-20 17:00    [from the cache]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and my Meterkast|Read the blog