lkml.org 
[lkml]   [2025]   [Apr]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH v7 04/10] dt-bindings: clock: Add Qualcomm QCS615 Display clock controller
From
On 14/04/2025 10:42, Taniya Das wrote:
> +
> +required:
> + - compatible
> + - reg

Drop

> + - clocks
> + - '#clock-cells'

Drop

> + - '#reset-cells'

Drop

Please look at other bindings when writing yours.

> + - '#power-domain-cells'
> +
> +allOf:
> + - $ref: qcom,gcc.yaml#
> +
> +unevaluatedProperties: false
> +
> +examples:
> + - |
> + #include <dt-bindings/clock/qcom,rpmh.h>
> + #include <dt-bindings/clock/qcom,qcs615-gcc.h>
> + clock-controller@af00000 {
> + compatible = "qcom,qcs615-dispcc";
> + reg = <0x0af00000 0x20000>;
> + clocks = <&rpmhcc RPMH_CXO_CLK>,
> + <&gcc GCC_DISP_GPLL0_DIV_CLK_SRC>,
> + <&mdss_dsi0_phy 0>,
> + <&mdss_dsi0_phy 1>,
> + <&mdss_dsi1_phy 0>,
> + <&mdss_dp_phy 0>,
> + <&mdss_dp_vco 0>;


Drop excessive spaces before '0'.


Best regards,
Krzysztof

\
 
 \ /
  Last update: 2025-04-15 07:26    [from the cache]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and my Meterkast|Read the blog