Messages in this thread |  | | From | Chenyuan Yang <> | | Date | Mon, 14 Apr 2025 07:52:11 -0500 | | Subject | Re: [PATCH] phy: qcom-qmp-usb: Fix an NULL vs IS_ERR() bug |
| |
Hi Johan and Krzysztof,
On Mon, Apr 14, 2025 at 3:13 AM Johan Hovold <johan@kernel.org> wrote: > > On Mon, Apr 14, 2025 at 10:08:18AM +0200, Krzysztof Kozlowski wrote: > > On 14/04/2025 09:40, Johan Hovold wrote: > > > > I'm afraid you're mistaken here. See __devm_ioremap() which can return > > > NULL. > > > > > Uh, you are right, I only checked devm_of_iomap in qmp_usb_iomap(). > > Anyway, the fix should be different - given function should either > > return ERR or NULL, not both, so devm_ioremap return value needs to be > > wrapped in ERR_PTR. > > Right, I already suggested that: > > https://lore.kernel.org/lkml/Z_yxxoa12N9rNn2z@hovoldconsulting.com/ > > Johan
I have submitted "[PATCH v2] phy: qcom-qmp-usb: Fix an NULL vs IS_ERR() bug", which fixes this issue based on your suggestions
-Chenyuan
|  |