Messages in this thread |  | | Date | Fri, 11 Apr 2025 21:19:09 -0500 | | Subject | Re: [PATCH v3 1/4] Documentation: Add AMD Zen debugging document | | From | Mario Limonciello <> |
| |
On 4/11/25 21:12, Bagas Sanjaya wrote: > On Thu, Apr 10, 2025 at 03:01:59PM -0500, Mario Limonciello wrote: >> v3: >> * Move debugging.rst to index.rst > > Do you plan to add more AMD-specific admin docs in the future?
I don't have any others planned right now. That move was because I noticed a toc warning with how I had it structured before.
> (BTW, I don't > follow v2 discussions.)
Don't worry; documentation hasn't been talked about in v2, it's all been discussion on the S5_RESET_STATUS.
> >> +As there are a lot of places that problems can occur, a debugging script has >> +been created that can help test for common problems and offer suggestions. >> + >> +https://git.kernel.org/pub/scm/linux/kernel/git/superm1/amd-debug-tools.git/tree/amd_s2idle.py >> + >> +If you have an s2idle issue, it's best to start with this and follow instructions >> +from its findings. If you continue to have an issue, raise a bug with the >> +report generated from this script. > > To mailing list following Documentation/admin-guide/reporting-issues.rst?
Actually I prefer them to drm/amd with the s2idle bug template. I'll add this detail.
> >> +First convert the GPIO number into hex. :: >> + >> + $ python3 -c "print(hex(59))" >> + 0x3b >> + >> +Next determine which ACPI table has the ``_EVT`` entry. For example: :: >> + >> + $ sudo grep EVT /sys/firmware/acpi/tables/SSDT* >> + grep: /sys/firmware/acpi/tables/SSDT27: binary file matches >> + >> +Decode this table::: >> + >> + $ sudo cp /sys/firmware/acpi/tables/SSDT27 . >> + $ sudo iasl -d SSDT27 > > Nit: two colons are sufficient for literal code-block.
Thanks.
> >> +To activate PM debugging, use the kernel command line option: ``pm_debug_messages``. >> + >> +Or enable the feature using the sysfs file: ``/sys/power/pm_debug_messages`` >> +Constraints that are not met will be displayed in the kernel log and can be >> +viewed using anything that processes the kernel ring buffer such as ``dmesg``` or >> +``journalctl``. > > "To activate PM debugging, either specify ``pm_debug_messagess`` kernel > command-line option at boot or write to ``/sys/power/pm_debug_messages``. > Unmet constraints will be displayed in the kernel log and can be > viewed by logging tools that process kernel ring buffer like dmesg or > journalctl." > >> +`patch <https://lore.kernel.org/amd-gfx/20250305051402.1550046-3-chiahsuan.chung@amd.com/T/#u>`_ > > What about that patchset status? It was not reviewed by upstream maintainers, > right? >
At the time I wrote this document it wasn't yet merged. It's been since merged, I will update to the commit details.
|  |