lkml.org 
[lkml]   [2025]   [Apr]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH net-next v2] net: ethernet: microchip: lan743x: Fix memory allocation failure
On Thu, Apr 10, 2025 at 09:40:34AM +0530, Thangaraj Samynathan wrote:
> The driver allocates ring elements using GFP_DMA flags. There is
> no dependency from LAN743x hardware on memory allocation should be
> in DMA_ZONE. Hence modifying the flags to use only GFP_ATOMIC
>
> Signed-off-by: Thangaraj Samynathan <thangaraj.s@microchip.com>
> ---
> v0
> -Initial Commit
>
> v1
> -Modified GFP flags from GFP_KERNEL to GFP_ATOMIC
> -added fixes tag
>
> v2
> -Resubmit net-next instead of net

Hi Thangaraj,

Thanks for the update. And sorry for not noticing this
in my earlier review. But I have some more feedback:

* I don't think it is correct to refer to this as fixing a failure
in the subject.

* I do think the subject prefix can be shortened to 'net: lan743x: '



Perhaps something more like this?

[PATCH net-next v3] net: lan743x: Allocate rings outside ZONE_DMA

And perhaps also mention in the commit message that this
is consistent with the other caller of lan743x_rx_init_ring_element().

Thanks!

\
 
 \ /
  Last update: 2025-04-11 18:58    [from the cache]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and my Meterkast|Read the blog