Messages in this thread |  | | Date | Sun, 9 Feb 2025 18:21:45 +0800 | | From | Herbert Xu <> | | Subject | Re: [RESEND PATCH V3] lib: 842: Improve error handling in sw842_compress() |
| |
On Tue, Jan 14, 2025 at 07:42:04PM +0530, Tanya Agarwal wrote: > From: Tanya Agarwal <tanyaagarwal25699@gmail.com> > > The static code analysis tool "Coverity Scan" pointed the following > implementation details out for further development considerations: > CID 1309755: Unused value > In sw842_compress: A value assigned to a variable is never used. (CWE-563) > returned_value: Assigning value from add_repeat_template(p, repeat_count) > to ret here, but that stored value is overwritten before it can be used. > > Conclusion: > Add error handling for the return value from an add_repeat_template() > call. > > Fixes: 2da572c959dd ("lib: add software 842 compression/decompression") > Signed-off-by: Tanya Agarwal <tanyaagarwal25699@gmail.com> > --- > V3: update title and reorganize commit description > V2: add Fixes tag and reword commit description > > Coverity Link: > https://scan5.scan.coverity.com/#/project-view/63683/10063?selectedIssue=1309755 > > lib/842/842_compress.c | 2 ++ > 1 file changed, 2 insertions(+)
Patch applied. Thanks. -- Email: Herbert Xu <herbert@gondor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
|  |