Messages in this thread |  | | Date | Tue, 11 Feb 2025 14:04:28 +0100 | | From | Andrew Lunn <> | | Subject | Re: [PATCH net-next v3 03/14] net: ethernet: qualcomm: Add PPE driver for IPQ9574 SoC |
| |
> > +#ifndef __PPE_H__ > > +#define __PPE_H__ > > + > > +#include <linux/compiler.h> > > +#include <linux/interconnect.h> > > + > > +struct device; > #include <linux/device.h> ? > > > +struct regmap; > Same with previous one, include it's header file? >
If the structure is opaque at this level, it is fine to not include the header. There is nothing in the header actually needed. By not including it, the build it faster. A large part of the kernel build time is spent processing headers, so less headers are better.
Andrew
|  |