lkml.org 
[lkml]   [2025]   [Feb]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 3/5] iommu/dart: Set DMA domain for locked DARTs
Hi Robin,

> > This is required.
>
> Now that we can, I'd really rather do this properly and not offer an
> identity domain in the first place when it's not available.

I'm reading through iommu.c but I don't see a way to avoid offering an
identity domain without the DMA override here, just reading through the
logic of iommu_get_default_domain_type. Could you point me to what you
have in mind?

Thanks,
Alyssa

> > --- a/drivers/iommu/apple-dart.c
> > +++ b/drivers/iommu/apple-dart.c
> > @@ -941,6 +941,8 @@ static int apple_dart_def_domain_type(struct device *dev)
> > return IOMMU_DOMAIN_IDENTITY;
> > if (!cfg->stream_maps[0].dart->supports_bypass)
> > return IOMMU_DOMAIN_DMA;
> > + if (cfg->stream_maps[0].dart->locked)
> > + return IOMMU_DOMAIN_DMA;
> > return 0;
> > }
> >
>

\
 
 \ /
  Last update: 2025-02-11 19:41    [from the cache]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and my Meterkast|Read the blog