Messages in this thread |  | | Date | Tue, 9 Dec 2025 09:39:05 +0200 | | From | Dmitry Baryshkov <> | | Subject | Re: [PATCH v4] arm64: dts: qcom: x1e80100: Add crypto engine |
| |
On Tue, Dec 09, 2025 at 12:57:29PM +0530, Harshal Dev wrote: > Hi, > > On 12/8/2025 9:26 PM, Konrad Dybcio wrote: > > On 12/8/25 1:32 PM, Harshal Dev wrote: > >> On X Elite, there is a crypto engine IP block similar to ones found on > >> SM8x50 platforms. > >> > >> Describe the crypto engine and its BAM. > >> > >> Signed-off-by: Harshal Dev <harshal.dev@oss.qualcomm.com> > >> --- > >> The dt-binding schema update for the x1e80100 compatible is here > >> (already merged): > >> > >> https://lore.kernel.org/all/20250213-dt-bindings-qcom-qce-x1e80100-v1-1-d17ef73a1c12@linaro.org/ > >> --- > > > > > >> + cryptobam: dma-controller@1dc4000 { > >> + compatible = "qcom,bam-v1.7.4", "qcom,bam-v1.7.0"; > >> + reg = <0x0 0x01dc4000 0x0 0x28000>; > >> + interrupts = <GIC_SPI 272 IRQ_TYPE_LEVEL_HIGH>; > >> + #dma-cells = <1>; > >> + iommus = <&apps_smmu 0x480 0x0>, > >> + <&apps_smmu 0x481 0x0>; > >> + qcom,ee = <0>; > >> + qcom,controlled-remotely; > >> + num-channels = <20>; > >> + qcom,num-ees = <4>; > >> + }; > >> + > >> + crypto: crypto@1dfa000 { > >> + compatible = "qcom,x1e80100-qce", "qcom,sm8150-qce", "qcom,qce"; > >> + reg = <0x0 0x01dfa000 0x0 0x6000>; > >> + dmas = <&cryptobam 4>, <&cryptobam 5>; > >> + dma-names = "rx", > >> + "tx"; > >> + iommus = <&apps_smmu 0x480 0x0>, > >> + <&apps_smmu 0x481 0x0>; > >> + interconnects = <&aggre2_noc MASTER_CRYPTO QCOM_ICC_TAG_ALWAYS > >> + &mc_virt SLAVE_EBI1 QCOM_ICC_TAG_ALWAYS>; > >> + interconnect-names = "memory"; > >> + }; > >> + > >> cnoc_main: interconnect@1500000 { > > > > Right as I hit enter for the rb message, I noticed the nodes you're > > adding are not sorted - please sort them wrt the unit address (@foo) > > and retain my tag then > > > > Not sure if I understand you Konrad.. I believe the nodes are already sorted > since address (crypto) @1dfa000 > address (cryptobam) @1dc4000? Do let me know what > I'm missing.
0x01dfa000 > 0x1500000, so no, your nodes are not properly sorted.
> > Thanks, > Harshal > > > Konrad >
-- With best wishes Dmitry
|  |