Messages in this thread |  | | Date | Mon, 8 Dec 2025 22:17:56 +0100 | | From | Jorge Marques <> | | Subject | Re: [PATCH v3 1/9] dt-bindings: iio: adc: Add adi,ad4062 |
| |
On Sat, Dec 06, 2025 at 04:58:22PM +0000, Jonathan Cameron wrote: > On Fri, 5 Dec 2025 16:12:02 +0100 > Jorge Marques <jorge.marques@analog.com> wrote: > > > Add dt-bindings for AD4062 family, devices AD4060/AD4062, low-power with > > monitor capabilities SAR ADCs. Each variant of the family differs in > > resolution. The device contains two outputs (gp0, gp1). The outputs can > > be configured for range of options, such as threshold and data ready. > > The device uses a 2-wire I3C interface. > > > > Signed-off-by: Jorge Marques <jorge.marques@analog.com> > > --- > > .../devicetree/bindings/iio/adc/adi,ad4062.yaml | 124 +++++++++++++++++++++ > > MAINTAINERS | 6 + > > 2 files changed, 130 insertions(+) > > > > diff --git a/Documentation/devicetree/bindings/iio/adc/adi,ad4062.yaml b/Documentation/devicetree/bindings/iio/adc/adi,ad4062.yaml > > new file mode 100644 > > index 0000000000000..a7a2ad761d1f0 > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/iio/adc/adi,ad4062.yaml > > + interrupts: > > + description: > > + The interrupt pins are digital outputs that can be configured at runtime > > + as multiple interrupt signals. Each can be configured as GP_INTR, RDY, > > + DEV_EN, logic low, logic high and DEV_RDY (GP1 only). > This is a bit confused. logic low / logic high aren't interrupt signals so I'd > not mention them here. Maybe something less detailed such as > > Two pins are available that can be configured as either a general purpose > digital output, device enable signal (used to synchronise other parts of > the signal chain with ADC sampling), device ready (GP1 only) or various > interrupt signals. If intended for use as a GPIO or device enable, will not > present here. > > For the binding I'm not sure we care about which interrupts are possible. > I guess even for device ready we might treat it as a onetime interrupt. Probably poll > it though - which requires a GPIO not an interrupt binding. If we don't need > to use that mode (and can poll a register or something like that) then no need > to mention that bit. Hi Jonathan,
Device enabled (DEV_EN) and device ready (DEV_RDY) are not implemented at this time at the driver. I believe it is fair to briefly mention in the dt-binding. I will use your suggested description.
Best regards, Jorge
|  |