Messages in this thread Patch in this message |  | | From | chenxiaosong.chenxiaosong@linux ... | | Subject | [PATCH 07/10] smb/client: introduce smb2maperror KUnit tests | | Date | Thu, 4 Dec 2025 12:58:15 +0800 |
| |
From: ChenXiaoSong <chenxiaosong@kylinos.cn>
The KUnit tests are executed when cifs.ko is loaded.
The maperror_test_check_sort() checks whether the array is properly sorted.
The maperror_test_get_err_map() checks whether the expected element can be correctly searched for in the smb2_error_map_table array.
Signed-off-by: ChenXiaoSong <chenxiaosong@kylinos.cn> --- fs/smb/Kconfig | 13 ++++++ fs/smb/client/smb2maperror.c | 77 ++++++++++++++++++++++++++++++++++++ 2 files changed, 90 insertions(+)
diff --git a/fs/smb/Kconfig b/fs/smb/Kconfig index ef425789fa6a..95b29d089e60 100644 --- a/fs/smb/Kconfig +++ b/fs/smb/Kconfig @@ -9,3 +9,16 @@ config SMBFS tristate default y if CIFS=y || SMB_SERVER=y default m if CIFS=m || SMB_SERVER=m + +config SMB_KUNIT_TEST + bool "SMB KUnit tests" if !KUNIT_ALL_TESTS + depends on KUNIT + default KUNIT_ALL_TESTS + help + Only useful for kernel devs running KUnit test harness and are not + for inclusion into a production build. + + For more information on KUnit and unit tests in general please refer + to the KUnit documentation in Documentation/dev-tools/kunit/. + + If unsure, say N. diff --git a/fs/smb/client/smb2maperror.c b/fs/smb/client/smb2maperror.c index f5d999f3b569..95e4a41ecc5a 100644 --- a/fs/smb/client/smb2maperror.c +++ b/fs/smb/client/smb2maperror.c @@ -2497,3 +2497,80 @@ void smb2_init_maperror(void) sizeof(struct status_to_posix_error), cmp_smb2_status, NULL); } + +#if IS_ENABLED(CONFIG_SMB_KUNIT_TEST) +#include <kunit/test.h> + +static void maperror_test_check_sort(struct kunit *test) +{ + bool is_sorted = true; + unsigned int i; + + for (i = 1; i < err_map_num; i++) { + if (smb2_error_map_table[i].smb2_status >= + smb2_error_map_table[i - 1].smb2_status) + continue; + + pr_err("smb2_error_map_table array order is incorrect\n"); + is_sorted = false; + break; + } + + KUNIT_EXPECT_EQ(test, true, is_sorted); +} + +static void +get_and_cmp_err_map(struct kunit *test, struct status_to_posix_error *expect) +{ + struct status_to_posix_error *result; + + result = smb2_get_err_map(expect->smb2_status); + KUNIT_EXPECT_PTR_NE(test, NULL, result); + KUNIT_EXPECT_EQ(test, expect->posix_error, result->posix_error); + KUNIT_EXPECT_STREQ(test, expect->status_string, result->status_string); +} + +static void maperror_test_get_err_map(struct kunit *test) +{ + struct status_to_posix_error expect; + + /* first element */ + expect = smb2_error_map_table[0]; + get_and_cmp_err_map(test, &expect); + + /* last element */ + expect = smb2_error_map_table[err_map_num - 1]; + get_and_cmp_err_map(test, &expect); + + expect = (struct status_to_posix_error) { + .smb2_status = STATUS_SERIAL_COUNTER_TIMEOUT, + .posix_error = -ETIMEDOUT, + .status_string = "STATUS_SERIAL_COUNTER_TIMEOUT", + }; + get_and_cmp_err_map(test, &expect); + + expect = (struct status_to_posix_error) { + .smb2_status = STATUS_IO_REPARSE_TAG_NOT_HANDLED, + .posix_error = -EOPNOTSUPP, + .status_string = "STATUS_REPARSE_NOT_HANDLED", + }; + get_and_cmp_err_map(test, &expect); +} + +/* + * Before running these test cases, the smb2_init_maperror() + * function is called first. + */ +static struct kunit_case maperror_test_cases[] = { + KUNIT_CASE(maperror_test_check_sort), + KUNIT_CASE(maperror_test_get_err_map), + {} +}; + +static struct kunit_suite maperror_suite = { + .name = "smb2-maperror", + .test_cases = maperror_test_cases, +}; + +kunit_test_suite(maperror_suite); +#endif /* CONFIG_SMB_KUNIT_TEST */ -- 2.43.0
|  |