Messages in this thread |  | | Date | Wed, 3 Dec 2025 11:28:03 +0100 | | From | Jan Kara <> | | Subject | Re: [PATCH v1] fs: PM: Fix reverse check in filesystems_freeze_callback() |
| |
On Tue 02-12-25 19:27:29, Rafael J. Wysocki wrote: > From: Rafael J. Wysocki <rafael.j.wysocki@intel.com> > > The freeze_all_ptr check in filesystems_freeze_callback() introduced by > commit a3f8f8662771 ("power: always freeze efivarfs") is reverse which > quite confusingly causes all file systems to be frozen when > filesystem_freeze_enabled is false. > > On my systems it causes the WARN_ON_ONCE() in __set_task_frozen() to > trigger, most likely due to an attempt to freeze a file system that is > not ready for that. > > Add a logical negation to the check in question to reverse it as > appropriate. > > Fixes: a3f8f8662771 ("power: always freeze efivarfs") > Cc: 6.18+ <stable@vger.kernel.org> # 6.18+ > Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
Looks good. Feel free to add:
Reviewed-by: Jan Kara <jack@suse.cz>
Honza
> --- > fs/super.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > --- a/fs/super.c > +++ b/fs/super.c > @@ -1188,7 +1188,7 @@ static void filesystems_freeze_callback( > if (!sb->s_op->freeze_fs && !sb->s_op->freeze_super) > return; > > - if (freeze_all_ptr && !(sb->s_type->fs_flags & FS_POWER_FREEZE)) > + if (!freeze_all_ptr && !(sb->s_type->fs_flags & FS_POWER_FREEZE)) > return; > > if (!get_active_super(sb)) > > > -- Jan Kara <jack@suse.com> SUSE Labs, CR
|  |