Messages in this thread |  | | Date | Wed, 3 Dec 2025 10:04:30 -0800 | | From | "Luck, Tony" <> | | Subject | Re: [PATCH v14 24/32] x86/resctrl: Add energy/perf choices to rdt boot option |
| |
On Tue, Dec 02, 2025 at 08:28:56AM -0800, Reinette Chatre wrote: > > diff --git a/arch/x86/kernel/cpu/resctrl/intel_aet.c b/arch/x86/kernel/cpu/resctrl/intel_aet.c > > index 46c64419ec10..50c8b4c50790 100644 > > --- a/arch/x86/kernel/cpu/resctrl/intel_aet.c > > +++ b/arch/x86/kernel/cpu/resctrl/intel_aet.c > > @@ -57,12 +57,16 @@ struct pmt_event { > > * struct event_group - Events with the same feature type ("energy" or "perf") and guid. > > * @feature: Type of events, for example FEATURE_PER_RMID_PERF_TELEM or > > * FEATURE_PER_RMID_ENERGY_TELEM, in this group. > > + * @name: Name for this group (used by boot rdt= option) > > This needs a new definition since multiple groups can have the same name now.
How about this:
* @type: Type (energy or perf) of this group.
That covers how different instances have the same string where "name" was confusing.
-Tony
|  |