lkml.org 
[lkml]   [2025]   [Dec]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH net-next v2 1/1] net: mdio: reset PHY before attempting to access ID register
> @@ -13,9 +13,12 @@
> #include <linux/phy.h>
> #include <linux/pse-pd/pse.h>
>
> +#include "../phy/mdio-private.h"

Relative imports are generally not allowed. It sometimes suggests
layering violations.

I'm not convinced the complexity and ugliness of partially registering
a device in order to be able to reset it, is worth the effort when we
have a simpler solution of just using the ID values in DT.

Give the merge window, i will mark this as change request for the
moment.

Andrew

---
pw-bot: cr

\
 
 \ /
  Last update: 2025-12-02 14:48    [from the cache]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and my Meterkast|Read the blog