Messages in this thread |  | | Date | Tue, 25 Nov 2025 10:50:59 +0100 | | From | Krzysztof Kozlowski <> | | Subject | Re: [PATCH v2 1/9] dt-bindings: iio: adc: Add adi,ad4062 |
| |
On Mon, Nov 24, 2025 at 10:18:00AM +0100, Jorge Marques wrote: > Add dt-bindings for AD4062 family, devices AD4060/AD4062, low-power with > monitor capabilities SAR ADCs. Each variant of the family differs in > resolution. The device contains two outputs (gp0, gp1). The outputs can > be configured for range of options, such as threshold and data ready. > The device uses a 2-wire I3C interface. > > Signed-off-by: Jorge Marques <jorge.marques@analog.com> > --- > .../devicetree/bindings/iio/adc/adi,ad4062.yaml | 123 +++++++++++++++++++++ > MAINTAINERS | 6 + > 2 files changed, 129 insertions(+) > > diff --git a/Documentation/devicetree/bindings/iio/adc/adi,ad4062.yaml b/Documentation/devicetree/bindings/iio/adc/adi,ad4062.yaml > new file mode 100644 > index 0000000000000..a25af66dd64d2 > --- /dev/null > +++ b/Documentation/devicetree/bindings/iio/adc/adi,ad4062.yaml > @@ -0,0 +1,123 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +# Copyright 2024 Analog Devices Inc. > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/iio/adc/adi,ad4062.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Analog Devices AD4062 ADC family device driver > + > +maintainers: > + - Jorge Marques <jorge.marques@analog.com> > + > +description: | > + Analog Devices AD4062 Single Channel Precision SAR ADC family > + > + https://www.analog.com/media/en/technical-documentation/data-sheets/ad4060.pdf > + https://www.analog.com/media/en/technical-documentation/data-sheets/ad4062.pdf > + > +properties: > + compatible: > + enum: > + - adi,ad4060 > + - adi,ad4062 > + > + reg: > + maxItems: 1 > + > + interrupts: > + description: > + The interrupt pins are digital outputs that can be configured at runtime > + as multiple interrupt signals. Each can be configured as GP_INTR, RDY, > + DEV_EN, logic low, logic high and DEV_RDY (GP1 only). RDY is the > + active-low data ready signal, indicates when new ADC data are ready to > + read. DEV_EN synchronizes the enable and power-down states of signal > + chain devices with the ADC sampling instant. DEV_RDY is an active-high > + signal that indicates when the device is ready to accept serial interface > + communications. In GP_INTR mode, the interrupt outputs one of the > + threshold detection interrupt signals (MIN_INTR, MAX_INTR or either). > + minItems: 1
So the wire/pin can be physically disconnected?
> + items: > + - description: > + gp0, interrupt line for GP0 pin, cannot be configured as DEV_RDY.
Write concise statements - duplicating gp0 is not helping. "GP0 pin, cannot be configured as DEV_RDY."
"GP1 pin, can be configured to any setting."
> + - description: > + gp1, interrupt line for GP1 pin, can be configured to any setting. > + > + interrupt-names:
Why this is not matching interrupts in number of items?
> + items: > + - const: gp0 > + - const: gp1 > + > + gpio-controller: > + description: > + Marks the device node as a GPIO controller. GPs not listed in > + interrupt-names are exposed as a GPO.
"not listed as interrupts are..."
> + > + '#gpio-cells': > + const: 2 > + description: > + The first cell is the GPIO number and the second cell specifies > + GPIO flags, as defined in <dt-bindings/gpio/gpio.h>.
Best regards, Krzysztof
|  |