Messages in this thread |  | | Date | Mon, 20 Jan 2025 16:35:00 +0530 | | Subject | Re: [PATCH v4 04/10] dt-bindings: clock: Add Qualcomm QCS615 Display clock controller | | From | Taniya Das <> |
| |
On 1/20/2025 2:22 PM, Dmitry Baryshkov wrote: > On Mon, Jan 20, 2025 at 10:10:11AM +0530, Taniya Das wrote: >> >> >> On 1/19/2025 5:23 PM, Rob Herring (Arm) wrote: >>> y bot found errors running 'make dt_binding_check' on your patch: >>> >>> yamllint warnings/errors: >>> >>> dtschema/dtc warnings/errors: >>> Documentation/devicetree/bindings/clock/qcom,qcs615-dispcc.example.dts:19:18: fatal error: dt-bindings/clock/qcom,qcs615-gcc.h: No such file or directory >>> 19 | #include <dt-bindings/clock/qcom,qcs615-gcc.h> >>> | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ >>> compilation terminated. >>> make[2]: *** [scripts/Makefile.dtbs:131: Documentation/devicetree/bindings/clock/qcom,qcs615-dispcc.example.dtb] Error 1 >>> make[2]: *** Waiting for unfinished jobs.... >>> make[1]: *** [/builds/robherring/dt-review-ci/linux/Makefile:1506: dt_binding_check] Error 2 >>> make: *** [Makefile:251: __sub-make] Error 2 >> >> The code https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/tree/include/dt-bindings/clock/qcom,qcs615-gcc.h >> >> The cover letter also has the series mentioned. > > Please. Stop using bindings for clock controllers in DT bindings for > other devices. It provides no benefits and complicates merging. >
Sure, I agree we should not refer the bindings, but I hope this is agreed upon and I could remove such references in upcoming bindings.
-- Thanks & Regards, Taniya Das.
|  |