lkml.org 
[lkml]   [2025]   [Jan]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v15 1/1] mctp pcc: Implement MCTP over PCC Transport
On Wed, 15 Jan 2025 14:52:17 -0500 admiyo@os.amperecomputing.com wrote:
> + rc = devm_add_action_or_reset(dev, mctp_cleanup_netdev, ndev);
> + if (rc)
> + goto cleanup_netdev;

devm_add_action_or_reset() calls the cleanup handler on failure,
so just

return devm_add_action_or_reset(dev, mctp_cleanup_netdev, ndev);

directly. As is you'll double free the netdev on failure.

> + return rc;
> +cleanup_netdev:
> + free_netdev(ndev);
--
pw-bot: cr

\
 
 \ /
  Last update: 2025-01-20 23:44    [from the cache]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and my Meterkast|Read the blog