Messages in this thread |  | | Date | Wed, 15 Jan 2025 15:39:32 +0100 | | From | Maxime Chevallier <> | | Subject | Re: [PATCH net 2/2] net: pcs: xpcs: actively unset DW_VR_MII_DIG_CTRL1_2G5_EN for 1G SGMII |
| |
Hello Vlad,
On Tue, 14 Jan 2025 18:47:21 +0200 Vladimir Oltean <vladimir.oltean@nxp.com> wrote:
> xpcs_config_2500basex() sets DW_VR_MII_DIG_CTRL1_2G5_EN, but > xpcs_config_aneg_c37_sgmii() never unsets it. So, on a protocol change > from 2500base-x to sgmii, the DW_VR_MII_DIG_CTRL1_2G5_EN bit will remain > set. > > Fixes: f27abde3042a ("net: pcs: add 2500BASEX support for Intel mGbE controller") > Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com>
Reviewed-by: Maxime Chevallier <maxime.chevallier@bootlin.com>
Thanks,
Maxime
|  |